SPRESENSE commented on a change in pull request #1446:
URL: https://github.com/apache/incubator-nuttx/pull/1446#discussion_r462667112
##########
File path: net/usrsock/usrsock_recvfrom.c
##########
@@ -418,6 +418,15 @@ ssize_t usrsock_recvfrom(FAR struct socket *psock, FAR
void *buf, size_t len,
*/
outaddrlen = state.valuelen_nontrunc;
+
+ /* If the MSG_PEEK flag is enabled, it will only peek
Review comment:
No, this patch is needed.
Actual buffer processing is in daemon, but usrsock wouldn't be passed the
receive process because usrsock determines no data. So set this flag again for
next recv() call.
##########
File path: net/usrsock/usrsock_recvfrom.c
##########
@@ -418,6 +418,15 @@ ssize_t usrsock_recvfrom(FAR struct socket *psock, FAR
void *buf, size_t len,
*/
outaddrlen = state.valuelen_nontrunc;
+
+ /* If the MSG_PEEK flag is enabled, it will only peek
Review comment:
No, this patch is needed.
Actual buffer processing is in daemon, but usrsock wouldn't be passed the
receive process because usrsock determines no data. So set this flag again for
next recv() call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
