yamt commented on PR #3048: URL: https://github.com/apache/nuttx-apps/pull/3048#issuecomment-2774125166
> > i'm not interested in the nshlib version of it. > > i didn't know the nshlib version already had the functionality. thank you for pointing out. > > implementation-wise, i prefer this PR because the nshlib implementation looks poor. (the use of strstr instead of a proper parsing of the options.) > > @yamt In summary, we need to remove one of them, and I think it doesn't matter which one. Using strstr can find substrings more quickly. do you know why we have two implementations of dd in the first place? (i dunno) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
