cederom opened a new pull request, #16015:
URL: https://github.com/apache/nuttx/pull/16015
## Summary
* BSD has its own BSD Make that is incompatible with GNU Make.
* When BSD is detected use (gnu) gmake in place of (bsd) make.
* This fixes nxstyle build inside tools/checkpatch.sh.
## Impact
* `tools/checkpatch.sh` now works correctly on BSD (`nxstyle` build).
## Testing
```
% uname -a
FreeBSD octagon 14.2-RELEASE-p1 FreeBSD 14.2-RELEASE-p1 GENERIC amd64
```
Before:
```
% ../nuttx.git/tools/checkpatch.sh -f path/to/file.c
==> MAKE IS make
make: "XXX/nuttx.git/tools/Makefile.host" line 25: Cannot open
/tools/Config.mk
make: "/XXX/nuttx.git/tools/Makefile.host" line 29: Invalid line type
(..)
make: Fatal errors encountered -- cannot continue
```
After:
```
% uname -a
FreeBSD octagon 14.2-RELEASE-p1 FreeBSD 14.2-RELEASE-p1 GENERIC amd64
octagon% ./tools/checkpatch.sh
USAGE: ./tools/checkpatch.sh [options] [list|-]
Options:
-h
-c spell check with codespell (install with: pip install codespell)
-u encoding check with cvt2utf (install with: pip install cvt2utf)
-r range check only (coupled with -p or -g)
-p <patch file names> (default)
-m Change-Id check in commit message (coupled with -g)
-g <commit list>
-f <file list>
- read standard input mainly used by git pre-commit hook as below:
git diff --cached | ./tools/checkpatch.sh -
Where a <commit list> is any syntax supported by git for specifying git
revision, see GITREVISIONS(7)
Where a <patch file names> is a space separated list of patch file names or
wildcard. or *.patch
$ uname -a
Linux octagon 5.15.0 FreeBSD 14.2-RELEASE-p1 GENERIC x86_64 GNU/Linux
$ ./tools/checkpatch.sh
USAGE: ./tools/checkpatch.sh [options] [list|-]
Options:
-h
-c spell check with codespell (install with: pip install codespell)
-u encoding check with cvt2utf (install with: pip install cvt2utf)
-r range check only (coupled with -p or -g)
-p <patch file names> (default)
-m Change-Id check in commit message (coupled with -g)
-g <commit list>
-f <file list>
- read standard input mainly used by git pre-commit hook as below:
git diff --cached | ./tools/checkpatch.sh -
Where a <commit list> is any syntax supported by git for specifying git
revision, see GITREVISIONS(7)
Where a <patch file names> is a space separated list of patch file names or
wildcard. or *.patch
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
