PruteanuVlad commented on code in PR #16016: URL: https://github.com/apache/nuttx/pull/16016#discussion_r2030221010
########## arch/xtensa/src/esp32/esp32_sha.c: ########## Review Comment: Hello and sorry for my late reply. So, just to make sure that I understood everything correctly. I will keep `arch/xtensa/src/esp32/esp32_crypto.c` . I will also keep `arch/xtensa/src/esp32/esp32_sha.c`, like my initial implementation. But, I will instead use functions from [components/hal/sha_hal.c](https://github.com/espressif/esp-hal-3rdparty/blob/066b294e58c78622175134cd88b5f27567d050e1/components/hal/sha_hal.c). I hope I got it right. I am not sure if your proposal was to only keep `arch/xtensa/src/esp32/esp32_crypto.c` and put everything there, but I think that it would be a good idea to have a separate file for SHA specifically. It would make everything cleaner, if, later, support for AES is added, for example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
