pussuw commented on code in PR #16154: URL: https://github.com/apache/nuttx/pull/16154#discussion_r2032957164
########## sched/task/task_fork.c: ########## @@ -137,22 +137,22 @@ FAR struct task_tcb_s *nxtask_setup_fork(start_t retaddr) /* Allocate a TCB for the child task. */ - child = kmm_zalloc(sizeof(struct task_tcb_s)); + child = kmm_zalloc(sizeof(struct tcb_s) + sizeof(struct task_group_s)); Review Comment: This is not the same thing as allocating sizeof(struct task_tcb_s). The correct alignment of task_group_s is not ensured anymore as tcb_s and task_group_s will now be implicitly packed. Is this a problem ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
