nuttxpr commented on PR #16198: URL: https://github.com/apache/nuttx/pull/16198#issuecomment-2799991334
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and points to a related PR for impact, it lacks crucial details. Specifically: * **Summary:** Needs more detail. *Why* is the dd config being removed? Is it obsolete, redundant, causing a conflict, etc.? How exactly is it being removed (deleted, commented out, etc.)? * **Impact:** Linking to another PR is insufficient. The impact needs to be explicitly stated within the PR itself. While the linked PR might provide context, reviewers shouldn't have to chase down external links to understand the impact. Explicitly address all the impact checklist items (user, build, hardware, documentation, security, compatibility). * **Testing:** "sim:nsh" is inadequate. What tests were run? What were the *results* of the tests, both before and after the change? Provide concrete log output or descriptions of observed behavior demonstrating that the change works as intended and hasn't introduced regressions. Just stating the target platform doesn't prove anything. In short, the PR needs to be significantly more detailed to meet the NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
