Fix-Point commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2049948161
##########
include/nuttx/wqueue.h:
##########
@@ -249,19 +249,11 @@ typedef CODE void (*worker_t)(FAR void *arg);
struct work_s
{
- union
- {
- struct
- {
- struct list_node node; /* Implements a double linked list */
- clock_t qtime; /* Time work queued */
- } s;
- struct wdog_s timer; /* Delay expiry timer */
- struct wdog_period_s ptimer; /* Period expiry timer */
- } u;
+ struct list_node node; /* Implements a double linked list */
+ clock_t qtime; /* Time work queued */
+ clock_t period; /* Periodical delay ticks */
Review Comment:
Done.
##########
libs/libc/wqueue/work_queue.c:
##########
@@ -89,7 +89,7 @@ static int work_qqueue(FAR struct usr_wqueue_s *wqueue,
work->worker = worker; /* Work callback. non-NULL means queued */
work->arg = arg; /* Callback argument */
- work->u.s.qtime = clock() + delay; /* Delay until work performed */
+ work->qtime = clock() + delay; /* Delay until work performed */
Review Comment:
Done.
##########
sched/wqueue/wqueue.h:
##########
@@ -83,13 +85,7 @@ struct kwork_wqueue_s
#ifdef CONFIG_SCHED_HPWORK
struct hp_wqueue_s
{
- struct list_node q; /* The queue of pending work */
- sem_t sem; /* The counting semaphore of the wqueue */
- sem_t exsem; /* Sync waiting for thread exit */
- spinlock_t lock; /* Spinlock */
- uint8_t nthreads; /* Number of worker threads */
- bool exit; /* A flag to request the thread to exit */
- int16_t wait_count;
+ struct kwork_wqueue_s wq;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
