acassis commented on code in PR #16236:
URL: https://github.com/apache/nuttx/pull/16236#discussion_r2050559289


##########
Documentation/applications/examples/elf/index.rst:
##########
@@ -4,9 +4,16 @@
 
 This example builds a small ELF loader test case. This includes several test
 programs under ``examples/elf`` tests. These tests are build using the 
relocatable
-ELF format and installed in a ROMFS file system. At run time, each program in
-the ROMFS file system is executed. Requires ``CONFIG_ELF``. Other configuration
-options:
+ELF format and installed in a configurable file system. At run time, the file 
system
+is mounted and each program is executed. Requires ``CONFIG_ELF``.
+Two distinct types of file systems are supported: internal (included in the 
NuttX binary)
+and external (not included in the binary). The external file systems need to 
be uploaded
+manually. For the internal file systems the sample supports the ``romfs`` and 
``cromfs``
+filesystems. For the external file systems any of the provided file systems 
can be used
+(``vfat``, ...), but also the ``romfs`` filesystem for which the image 
(``romfs.img``) is
+automatically generated.

Review Comment:
   Maybe include the information that these filesystem when flashed in the 
internal Flash cannot be modified (unless the progmem be used with it, TODO).



##########
Documentation/applications/examples/elf/index.rst:
##########
@@ -35,28 +42,26 @@ options:
 
    If you use GCC to link, you make also need to include ``-nostdlib``.
 
-3. This example also requires ``genromfs``. ``genromfs`` can be build as part 
of the
-   nuttx toolchain. Or can built from the ``genromfs`` sources that can be 
found
-   in the NuttX tools repository (``genromfs-0.5.2.tar.gz``). In any event, the
-   ``PATH`` variable must include the path to the genromfs executable.
-
-4. ELF size: The ELF files in this example are, be default, quite large because
+3. ELF size: The ELF files in this example are, be default, quite large because

Review Comment:
   @Laczen maybe for romfs you should keep the information about the need for 
genromfs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to