sumpfralle commented on code in PR #16302: URL: https://github.com/apache/nuttx/pull/16302#discussion_r2072741627
########## .codespell-ignore-lines: ########## @@ -0,0 +1,15 @@ + * Set max equivalent capacitance for sheild channel. Review Comment: Thank you for taking a detailed look! Yes, this file is supposed to contain only *valid exceptions*. It looks like I was tricked by the existence of the function named `touch_lh_waterproof_get_sheild_driver` into believing, that this spelling could be intended. I corrected the remaining occurrences of the word "sheild" and removed the exception. But I kept the function names containing this string unchanged for now (within the scope of this PR). Do you have a suggestions, how to treat these function names? * A) keep them unchanged (annoying, but compatibility-friendly) * B) rename them (may break compilation for *very few* users, but is easy to fix) * C) rename and add backwards-compatibility `define` for allow both the wrong spelling and the correct spelling Your thoughts? (I will submit this in a separate PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
