tmedicci commented on code in PR #16320: URL: https://github.com/apache/nuttx/pull/16320#discussion_r2075363360
########## arch/risc-v/src/common/espressif/Bootloader.mk: ########## @@ -35,8 +35,14 @@ BOOTLOADER_CONFIG = $(BOOTLOADER_SRCDIR)/bootloader.conf MCUBOOT_SRCDIR = $(BOOTLOADER_SRCDIR)/mcuboot MCUBOOT_ESPDIR = $(MCUBOOT_SRCDIR)/boot/espressif -MCUBOOT_URL = https://github.com/mcu-tools/mcuboot MCUBOOT_TOOLCHAIN = $(TOOLSDIR)/mcuboot_toolchain_espressif.cmake +ifndef MCUBOOT_VERSION + MCUBOOT_VERSION = $(CONFIG_ESPRESSIF_MCUBOOT_VERSION) Review Comment: It's redundant. We already checked for the variable being (or not) defined one line before (and we did that to be more explicit). Are there other reasons that I'm missing here? (just for some background: this PR is highly inspired by https://github.com/apache/nuttx/pull/9545/commits/f8d8852cd6b722255f2da2ffe72b3d2fd7cd8b37, which our internal CI is using for two years) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
