gpoulios commented on PR #3074: URL: https://github.com/apache/nuttx-apps/pull/3074#issuecomment-2872873812
> Is the name `tee/` correct, shouldn't it be `optee/`? The directory is named tee/ because there might be some other implementation in the future (e.g. libamdteec or whatever). Do you still want me to rename it? > Can we please move `optee/` under some existing group/category to keep things clean i.e. `system/optee`? I considered that but then I thought, it’s not exactly a system thing, right? Just didn’t fit alongside the other packages under system/. But if you want it there, sure. > This will be initial commit so some words of introduction would be nice to put into a commit - for instance what is this library, whers is the homepage and documentation, etc You mean put this info on the commit message of the commit introducing libteec? > + some info in the src headers so newcomers will know what this is :-) You lost me here, can you show me an example please? There are no header files introduced by us. Only the library’s (downloaded) headers. As for new comers, if they have any aspirations to write an OPTEE client app in NuttX, I’m pretty sure they know already those things, but sure I can put a few links here and there. > Mixed case identifiers comes from the library API so we need to accept that. Yes, that’s in the NuttX PR i mentioned in the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
