xiaoxiang781216 commented on PR #16401: URL: https://github.com/apache/nuttx/pull/16401#issuecomment-2886985041
> This set of changes causes CI failures for the following reasons: > > * `error: Mixed case identifier found`: unrelated problematic naming of variables. I think, these should be fixed by contributors maintaining these specific modules. > let's ignore it. > * [codespell] `nd`: Maybe the variable should be renamed in order to avoid false positives. I think, this should be fixed by contributors maintaining these specific modules. > > * [codespell] `clen`: see before. > > * [codespell] `ist`: This abbreviation for "Interrupt Stack Table" is used in four files (related to the `x86_64` architecture). I am not sure, whether it shall be renamed or whether a global (or line-based) exception should be added. IMO this should be deferred to a maintainer of this module/architecture. > > * [codespell] `noral`: I am not sure, which word the original author intended [there](https://github.com/apache/nuttx/blob/55f85dd727e670151d7455b22880a60036b3fe9f/arch/xtensa/src/esp32s3/hardware/esp32s3_rtccntl.h#L4252) (two occurrences). > this should be `normal` by checking the similar places > * `drivers/video/vnc/vnc_keymap.c` (blank lines): I think, these blank lines are correct (see [source](https://github.com/apache/nuttx/blob/master/drivers/video/vnc/vnc_keymap.c#L120)). > > * [codespell] `menas`: I am not sure, which word the original author intended [there](https://github.com/apache/nuttx/blob/master/include/nuttx/power/pm.h#L628) (two occurrences). should be `means` > > * [codespell] `configed` / `INDX` / `vaild` / `avalaible`: These variable names will be fixed in another PR containing rather _questionable_ changes (to be proposed after this PR is merged). > > * `include/nuttx/net/*.h` (long lines): These are copyright statements. I guess, these should not be wrapped. > > * `libs/libm/libm/lib_lgamma.c: error: Operator/assignment must be preceded with whitespace`: I think, the scientific number expression with a positive exponent (`123e+4`) is misdetected as a problem by `nxstyle`. I failed to see a quick way for fixing this issue in `nxstyle`. Thus, I would suggest to ignore this error here. one fix is changing `+00` to `-00`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
