jlaitine opened a new pull request, #16423:
URL: https://github.com/apache/nuttx/pull/16423
## Summary
This PR contains two bugfixes and one cleanup commit for semaphore/mutex
code:
- There was a bug in sem_post for a mutex, setting "blocking" bit
incorrectly. This may cause errors in SMP systems
- There is no need to clear the "blocking" bit in sem_waitirq, this is just
extra code
- Holders for mutex were not freed correctly, leading to consuming extra
holder structures and in worst case a crash if
a leftover holder was pointing to a deleted thread/task
These errors were found in our internal reliability testing and debugging
the issues found.
## Impact
This fixes some (rare) stability issues after PR #16194
## Testing
Tested on rv-virt:smp and on real hardware (mpfs 250t, SMP), with real
application and with ostest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
