patacongo commented on a change in pull request #1517:
URL: https://github.com/apache/incubator-nuttx/pull/1517#discussion_r466025235
##########
File path: sched/Kconfig
##########
@@ -219,7 +219,7 @@ config START_DAY
config MAX_WDOGPARMS
int "Maximum number of watchdog parameters"
- default 4
+ default 2
Review comment:
I think if you change CONFIG_MAX_WDOGPARMS to 2, you should also change
the prototype of wd_start() from:
int wd_start(WDOG_ID wdog, int32_t delay, wdentry_t wdentry, int argc,
...);
to
int wd_start(WDOG_ID wdog, int32_t delay, wdentry_t wdentry, wdparm_t
arg1, wdparm_t arg2);
Problems with the use of the variadic wd_start() was also by @yamt and
others in a previous PR. At that time, they wanted to change the `int argc,
...` to a structure pointer. I resisted that change but if
_CONFIG_MAX_WDOGPARMS_ is set to 2, then there is no reason to pass a variable
argument and we should then honor the concerns of @yamt and others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
