jlaitine commented on PR #16510: URL: https://github.com/apache/nuttx/pull/16510#issuecomment-2962384810
Ah. The g_segger_lock existed only for note_sysview. It only compiled for non-SMP systems previously, because the basic spin lock got defined into irq lock, not using the global variable at all. Moved the g_segger_lock into an own file. An alternative for this would have been to define it in SEGGER_RTT; but for that we'd have to create a patch file and Make.defs change to apply that. I believe it is cleaner to just add a "common" c file for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
