jlaitine commented on code in PR #16512: URL: https://github.com/apache/nuttx/pull/16512#discussion_r2142055199
########## drivers/segger/segger.c: ########## @@ -0,0 +1,38 @@ +/**************************************************************************** + * drivers/segger/segger.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/spinlock.h> + +/**************************************************************************** + * Public Data + ****************************************************************************/ + +spinlock_t g_segger_lock = SP_UNLOCKED; +ptrdiff_t g_segger_offset = PTRDIFF_MAX; Review Comment: If you wanted to actually use this variable for something, where is it supposed to be set? The default value of PTRDIFF_MAX wouldn't do anything good I suppose. I am a bit confused about the whole offset thingy, and just always kept it at 0 myself. Instead, I just define an uncached memory section in the linker script and set the CONFIG_SEGGER_RTT_SECTION to point in there (e.g. CONFIG_SEGGER_RTT_SECTION=".rtt"). Could you add some info about how to use this config? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
