jlaitine commented on code in PR #16466: URL: https://github.com/apache/nuttx/pull/16466#discussion_r2152247517
########## drivers/serial/serial.c: ########## @@ -901,12 +901,21 @@ static ssize_t uart_readv(FAR struct file *filep, FAR struct uio *uio) #ifdef CONFIG_SERIAL_IFLOWCONTROL_WATERMARKS unsigned int nbuffered; unsigned int watermark; +# ifndef CONFIG_ARCH_LD_16BIT_NOT_ATOMIC + int16_t head; Review Comment: I find it a bit strange that the 16-bit indexes are signed, but th 8-bit versions are unsigned. But I guess a good reasoning is not to change the original 16-bit indexies unnecessarily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
