JianyuWang0623 commented on code in PR #3098:
URL: https://github.com/apache/nuttx-apps/pull/3098#discussion_r2152337199


##########
system/fastboot/fastboot.c:
##########
@@ -122,10 +139,20 @@ struct fastboot_file_s
   off_t offset;
 };
 
+struct fastboot_transport_s
+{
+  int (*init)(FAR struct fastboot_ctx_s *);
+  void (*deinit)(FAR struct fastboot_ctx_s *);
+  ssize_t (*read)(FAR struct fastboot_ctx_s *, FAR void *, size_t);
+  int (*write)(FAR struct fastboot_ctx_s *, FAR void *, size_t);
+};
+
 struct fastboot_ctx_s
 {
   int usbdev_in;
   int usbdev_out;
+  int server_fd;  /* fd for the TCP socket */
+  int conn_fd;    /* fd for the accepted socket */

Review Comment:
   thanks for good idea, should we union them first?
   as comment below, we plant to support USB and TCP at the same time, those 
fds may need kept open at the same time in the next patch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to