jeanthom commented on code in PR #3110:
URL: https://github.com/apache/nuttx-apps/pull/3110#discussion_r2167669310
##########
system/settings/settings.c:
##########
@@ -494,24 +496,24 @@ static int get_ip(FAR setting_t *setting, FAR struct
in_addr *ip)
{
int ret;
assert(setting);
- if ((setting->type != SETTING_IP_ADDR) &&
- (setting->type != SETTING_STRING))
- {
- return -EACCES;
- }
- if (setting->type == SETTING_IP_ADDR)
+ switch (setting->type)
{
- memcpy(ip, &setting->val.ip, sizeof(struct in_addr));
- ret = OK;
- }
- else if (setting->type == SETTING_STRING)
- {
- ret = inet_pton(AF_INET, setting->val.s, ip);
- }
- else
- {
- ret = -EINVAL;
+ case SETTING_IP_ADDR:
+ {
Review Comment:
Hehe no worries 😄 I'll fix a minor code style issue (there is currently no
line return after the case 'break' statement) and revert the commit tomorrow
morning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
