TimJTi opened a new pull request, #3119:
URL: https://github.com/apache/nuttx-apps/pull/3119

   ## Summary
   
   When trying to enable and use the thttp net utility, it was found that CGI 
apps didnt send any http responses of data from the CGI app back to the browser 
client,
   
   Investigation revealed this was due to the net socket being opened with the  
O_CLOEXEC flag set.
   
   This is the result, I believe, of a PR last year [here]( 
https://github.com/apache/nuttx-apps/pull/2595).
   
   See [this](https://github.com/apache/nuttx-apps/issues/3111) issue.
   
   In correcting the issue, some complier warnings were encountered and fixed, 
along with a Kconfig error and an omission, and the opportunity was taken to 
improve some help text within Kconfig.
   
   This is why there are two commits in the PR.
   
   ### Question
   
   The cgi_child app that is spawned closes all open file descriprors except 
stdin, stdout, stderr and the socket's descriptor, up to a maximum number of 
file descriptors as set via Kconfig.
   
   See 
[here](https://github.com/apache/nuttx-apps/blob/master/netutils/thttpd/thttpd_cgi.c#L773).
   
   Should the Kconfig option be removed and the function use `OPEN_MAX` instead?
   
   ## Impact
   
   No impact on existing usage of this netutil, other than to allow it work 
properly now!
   
   ## Testing
   
   This has been tested as part of my own application development, using a 
custom SAMA5D27C-D1G processor, with the webserver running via CDC-NCM.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to