no1wudi commented on a change in pull request #356:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/356#discussion_r467456882
##########
File path: interpreters/duktape/duk_cmdline.patch
##########
@@ -21,3 +21,15 @@ diff --color -ur duktape-2.5.0/src-noline/duk_config.h
duktape-2.5.0-modifed/src
-#define DUK_USE_DATE_PRS_STRPTIME
+#undef DUK_USE_DATE_PRS_STRPTIME
#define DUK_USE_DATE_FMT_STRFTIME
+
+
+diff --color -ur duktape-2.5.0/src-noline/duk_config.h
duktape-2.5.0-modifed/src-noline/duk_config.h
Review comment:
The config header detect the sim platform as Linux or macOS even unix,
so we need these changes.
Maybe we can add NuttX platform defination into duktape.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
