Ouss4 commented on a change in pull request #1535:
URL: https://github.com/apache/incubator-nuttx/pull/1535#discussion_r467460279
##########
File path: tools/testbuild.sh
##########
@@ -239,6 +244,14 @@ function build {
fail=1
fi
+ # Enable debug symbols if requested. We do this after refresh
+ # to not trigger a failure by including this feature
+
+ if [ ${FORCESYMBOLS} -eq 1 ]; then
+ kconfig-tweak --file $nuttx/.config --enable CONFIG_DEBUG_SYMBOLS
+ makefunc olddefconfig
Review comment:
kconfig-tweek doesn't update the rest of the .config. We need to run
olddefconfig to enable/disable what's affected by our change.
> BTW, how about we replace sed with kconfig-tweak in other location?
I think it's a good idea to replace sed by kconfig-tweek.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
