michallenc opened a new pull request, #3136:
URL: https://github.com/apache/nuttx-apps/pull/3136

   ## Summary
   
   **619ea01 boot/nxboot/loader/flash.c: open partition with O_DIRECT flag**
   
   There is no need to use buffers in a bootloader. We expect a sequential
   access, therefore we just need to erase the erase page before writing
   to it for the first time, which is something FTL layer already takes
   care of.
   
   **95e4b0c boot/nxboot/loader/boot.c: copy partition with blocksize large 
writes**
   
   The previous logic `MAX(info_from.blocksize, info_where.blocksize)` was
   incorrect. The most effective access with by writing the entire
   size of the block, therefore just decide the size based on the
   target page size.
   
   ## Impact
   
   Nxboot now utilizes changes presented in 
https://github.com/apache/nuttx/pull/16642. Should not have impact on current 
implementation as the additional flags are ignored if changes in 
https://github.com/apache/nuttx/pull/16642 are not applied.
   
   ## Testing
   
   Tested with https://github.com/apache/nuttx/pull/16642 patch applied. Nxboot 
successfully updates and reverts new image. All works as before, but additional 
buffering is skipped.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to