acassis commented on code in PR #16767:
URL: https://github.com/apache/nuttx/pull/16767#discussion_r2232899599
##########
drivers/pci/pci_qemu_epc.c:
##########
@@ -803,7 +803,7 @@ static int qemu_epc_probe(FAR struct pci_device_s *dev)
}
qep->pdev = dev;
- epc = pci_epc_create("qemu_epc", qep, &g_qemu_epc_ops);
+ epc = pci_epc_create("qemu_epc", qep, NULL, 0, &g_qemu_epc_ops);
if (epc == NULL)
{
pcierr("Failed to create epc device\n");
Review Comment:
```suggestion
pcierr("Failed to create qemu_epc device\n");
##########
drivers/pci/pci_epc.c:
##########
@@ -993,6 +996,16 @@ pci_epc_create(FAR const char *name, FAR void *priv,
return NULL;
}
+ if (dma_addr && dma_len)
+ {
+ epc->dmaheap = mm_initialize_pool("pci_dma", dma_addr, dma_len, NULL);
+ if (!epc->dmaheap)
+ {
+ pcierr("creat dma heap error \n");
Review Comment:
```suggestion
pcierr("Create DMA heap error \n");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
