michallenc commented on issue #3146:
URL: https://github.com/apache/nuttx-apps/issues/3146#issuecomment-3133670580
I am not against moving the header to `apps/include/boot`, there was no
particular reason why I included it in `apps/boot/nxboot/include/`, just kept
the same style used already for mcuboot. And it's true moving this to common
include directory would make more sense as it would follow other examples.
Regarding `nxboot_progress`, I think it should be public API as well. The
idea is you don't have to use `boot/nxboot/nxboot_main.c` as an entry point,
but you can write your own if you want/need to.
Regarding convoluted paths, it shouldn't be necessary. `Make.defs` in
`apps/boot/nxboot`
```
ifneq ($(CONFIG_BOOT_NXBOOT),)
CONFIGURED_APPS += $(APPDIR)/boot/nxboot
CFLAGS += ${INCDIR_PREFIX}$(APPDIR)/boot/nxboot/include
endif
```
should ensure the header is installed and only `<nxboot.h>` include is
required. The move to `apps/include/boot` would prolong it to
`<boot/nxboot.h>`, but it's not a big deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
