mlyszczek commented on PR #16793: URL: https://github.com/apache/nuttx/pull/16793#issuecomment-3134294223
Well, I don't really feel in the position to comment on such changes, but since you've asked ;) This is public function so it will probably break someone's code. But change is rather minor and it will not silently break anyone's code (such case should never ever happen). So if this is documented in "upgrade" section of documentation with explanation how to properly migrate, I think this should be fine, as it's rather quick fix. I would consider adding very short info after compilation fails, that breakage might be caused by API change and that user should refer to documentation (link to page). Maybe even lock it behind kconfig like `CONFIG_NUTTX_UPGRADE_12_10_READ`, so user can silent warning after he confirms there is no more API breakages? It could be different mechanism, but I think if nuttx changes API, there should be some explicit info for the user that upgrades versions that API has been changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
