cederom commented on PR #16823: URL: https://github.com/apache/nuttx/pull/16823#issuecomment-3172083285
* Thanks @acassis, since requirement for marking breaking changes is part of Contributing Guide for 3 months but everyone seems to ignore marking, maybe other way will work. * There is nothing wrong in `[BREAKING]` mark, no bad message, quite opposite, someone who finds their code broken after update will easily find possible cause that way. * I do insist to mark breaking changes in git commit topic and PR message title as this is first place to search (git log search and changelog). * Putting "BREAKING CHANGE" in the git commit message may be okay, but we also need this "!" mark before ":" as stated in https://www.conventionalcommits.org/en/v1.0.0/. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
