wenquan2015 commented on PR #14595:
URL: https://github.com/apache/nuttx/pull/14595#issuecomment-3186414042

   
   
   
   > > @nuttxs hi, this patch results the struct sockaddr_storage aligned by 2, 
if a struct contains the struct sockaddr_storage as member peer and have a 2 
bytes length member in front of the peer member, it will cause address 
misaligned access warning in a 32-bit OS
   > 
   > @wenquan2015 Would moving the members out of the packed sub-structure into 
a flat layout—while still maintaining 8-byte alignment —resolve the current 
issue? Since it’s unclear whether any applications rely on the sub-structure 
(ss_data[1]), adding overall 8-byte alignment at the top level of the structure 
might be the safer choice.
   > 
   > The repair PR:#16845 has been submitted. Please review and verify
   
   @nuttxs hi, repair PR:https://github.com/apache/nuttx/pull/16845 I have 
verified ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to