acassis commented on PR #16838: URL: https://github.com/apache/nuttx/pull/16838#issuecomment-3189682508
> @acassis @fdcavalcanti Example app, new defconfig and docs added, do they look good? If so, I'm ready to squash. > > (Also, out of curiosity, why not squash [at the PR level](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits)?) Become a PR could have not direct related commits. When you fix review comment, normally they are related to some specific commit and you need to squash the corrections to that commit. Case you have different commits and the modifications are related to only one of them, then you need to use git rebase -i to squash to that specific commit that needs to incorporate the modifications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
