xiaoxiang781216 commented on code in PR #16849: URL: https://github.com/apache/nuttx/pull/16849#discussion_r2281156872
########## arch/arm/src/common/Toolchain.defs: ########## @@ -208,15 +208,16 @@ endif ifeq ($(CONFIG_ARM_TOOLCHAIN_CLANG),y) - CC = clang - CXX = clang++ - CPP = clang -E -P -x c - LD = ld.lld -m armelf - STRIP = llvm-strip --strip-unneeded - AR = llvm-ar rcs - NM = llvm-nm - OBJCOPY = llvm-objcopy - OBJDUMP = llvm-objdump + CC = clang + CXX = clang++ + CPP = clang -E -P -x c + LD = ld.lld -m armelf + STRIP = llvm-strip --strip-unneeded + AR = llvm-ar rcs + AR_EXTRACT = llvm-ar x Review Comment: how about `UNAR` like ZIP/UNZIP which also avoid change other lines for alignemnt? ########## arch/arm/src/common/Toolchain.defs: ########## @@ -208,15 +208,16 @@ endif ifeq ($(CONFIG_ARM_TOOLCHAIN_CLANG),y) - CC = clang - CXX = clang++ - CPP = clang -E -P -x c - LD = ld.lld -m armelf - STRIP = llvm-strip --strip-unneeded - AR = llvm-ar rcs - NM = llvm-nm - OBJCOPY = llvm-objcopy - OBJDUMP = llvm-objdump + CC = clang + CXX = clang++ + CPP = clang -E -P -x c + LD = ld.lld -m armelf + STRIP = llvm-strip --strip-unneeded + AR = llvm-ar rcs + AR_EXTRACT = llvm-ar x Review Comment: how about `UNAR` like ZIP/UNZIP which also avoid change other lines for alignment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
