davids5 commented on pull request #1554:
URL: https://github.com/apache/incubator-nuttx/pull/1554#issuecomment-671912002
> @davids5 I worked a long day and got the basic implementation in place in
one (long) day. It involved more code changes that I expected from implementing
the same feature in ROMFS. The main complexity increase is that ROMFS uses a
block driver, but CROMFS accesses the FS image directly in ROM. That should
perform better, but it means that I can not read a hard link directory entry
and modify it so that it has the same properties as the link target entry.
Rather, I had to add additional writable data structures and more complexity
than I anticipated.
>
> Could you help with verification and merge (when we are absolutely
confident that all is in order). My testing is light and PX4 has a vested
interest in getting this done right and quickly.
I am testing this on today's master....Will report back in a bit.
I had to fix this:
```
dirent/lib_ftw.c: In function 'ftw':
dirent/lib_ftw.c:38:21: error: cast between incompatible function types from
'ftw_cb_t' {aka 'int (*)(const char *, const struct stat *, int)'} to 'int
(*)(const char *, const struct stat *, int, struct FTW *)'
[-Werror=cast-function-type]
38 | return nftw(path, (nftw_cb_t)fn, fdlimit, FTW_PHYS);
| ^
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
