Re: [PR] [DRAFT] github: check git commit format [nuttx]

[via GitHub]

simbit18 commented on code in PR #16912:
URL: https://github.com/apache/nuttx/pull/16912#discussion_r2303521890


##########
tools/checkpatch.sh:
##########
@@ -279,12 +282,64 @@ check_patch() {
 }
 
 check_msg() {
+  first=$(head -n1 <<< "$msg")
+  signedoffby_found=0
+  num_lines=0
+  max_line_len=72
+  min_num_lines=5
+
   while read; do
     if [[ $REPLY =~  ^Change-Id ]]; then
       echo "Remove Gerrit Change-ID's before submitting upstream"
       fail=1
     fi
+
+    if [[ $REPLY =~  ^VELAPLATO ]]; then
+      echo "Remove VELAPLATO before submitting upstream"
+      fail=1
+    fi
+
+    if [[ $REPLY =~  ^[Ww][Ii][Pp]: ]]; then
+      echo "Remove WIP before submitting upstream"
+      fail=1
+    fi
+
+    if [[ $REPLY =~  ^[Ww][Ii][Pp]: ]]; then
+      echo "Remove WIP before submitting upstream"

Review Comment:
   Is it necessary to repeat the check?
   
   ```
   if [[ $REPLY =~  ^[Ww][Ii][Pp]: ]]; then
         echo "Remove WIP before submitting upstream"
         fail=1
   fi
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org