acassis commented on code in PR #16923:
URL: https://github.com/apache/nuttx/pull/16923#discussion_r2305365839


##########
arch/arm/src/xmc4/Kconfig:
##########
@@ -326,6 +326,24 @@ config XMC4_USIC0_CHAN1_ISI2S
 
 endchoice # USIC0 Channel 1 Protocol
 
+config XMC4_USIC0_CHAN0_TX_BUFFER_SIZE
+       int "Unused channel 0 Tx Fifo Buffer Size"
+       depends on !XMC4_USIC0_CHAN0_ISUART
+       default 16
+       ---help---
+               Should be a power of 2 between 2 and 64
+               The sum of Rx and Tx buffers sizes of both
+               channels should be inferior to 64

Review Comment:
   @adriendesp could you please more details here? I understand that USIC0 can 
be used as UART, SPI, I2C, etc and when not used as UART to can use the buffer 
for other features. But the "Unused" is confusing and there is not further 
explanation in the help.
   Maybe: "Channel 0 Tx FIFO Buffer Size (non-UART)" will be more clear, but 
yet it is nice to have a better explanation in the help beyond the size 
information.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to