ppisa commented on PR #16911: URL: https://github.com/apache/nuttx/pull/16911#issuecomment-3232813793
The Linux kernel style for MMD PHY registers access is proposed in alternative pull request #16926 which superseded this request if approved. Combining of Clause 22 and Clause 45 accesses in the single IOCTL is a little more readable but does not resources for another and NuttX specific IOCTL. There should be followup discussion how to report which MACs are acapable of C45 accesses to PHYs. All controllers with MDIO IOCTLs support should be revised to not attempt interpret incorrect way C45 as C22 and vice versa. Current state is that there are even no checks that classical MDIO addresses and registers are in range. But it should be discussed the first and is mostly another topic than MMD and PLCA for T1S. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
