patacongo commented on a change in pull request #1562:
URL: https://github.com/apache/incubator-nuttx/pull/1562#discussion_r468621366
##########
File path: arch/arm/src/common/arm_createstack.c
##########
@@ -220,7 +220,8 @@ int up_create_stack(FAR struct tcb_s *tcb, size_t
stack_size, uint8_t ttype)
/* Save the adjusted stack values in the struct tcb_s */
tcb->adj_stack_ptr = (uint32_t *)top_of_stack;
- tcb->adj_stack_size = size_of_stack;
+ tcb->adj_stack_size = size_of_stack -
+ sizeof(struct tls_info_s);
Review comment:
What if sizeof(struct tls_info_s) is not an multiple of 8 bytes. Does
it matter if the far end of the adjusted stack is not aligned properly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
