patacongo commented on a change in pull request #357:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/357#discussion_r468636769
##########
File path: netutils/ftpc/ftpc_connect.c
##########
@@ -214,7 +210,7 @@ int ftpc_reconnect(FAR struct ftpc_session_s *session)
fptc_getreply(session);
}
- wd_cancel(session->wdog);
+ wd_cancel(&session->wdog);
Review comment:
Not a legal OS interface. See wd_start() comments above.
##########
File path: netutils/ftpc/ftpc_connect.c
##########
@@ -152,8 +148,8 @@ int ftpc_reconnect(FAR struct ftpc_session_s *session)
/* Set up a timer to prevent hangs */
- ret = wd_start(session->wdog,
- session->conntimeo, ftpc_timeout, 1, session);
+ ret = wd_start(&session->wdog, session->conntimeo,
Review comment:
This function cannot be called in PROTECTED or KERNEL build modes not
can the interrupt handling logic access user space. Remember that the callback
is in the context of the timer interrupt handler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
