patacongo commented on a change in pull request #1545:
URL: https://github.com/apache/incubator-nuttx/pull/1545#discussion_r468673077
##########
File path: arch/arm/src/cxd56xx/cxd56_rtc.c
##########
@@ -254,13 +254,8 @@ static void cxd56_rtc_initialize(int argc, ...)
{
struct timespec ts;
#ifdef CONFIG_CXD56_RTC_LATEINIT
- static WDOG_ID s_wdog = NULL;
- static int s_retry = 0;
-
- if (s_wdog == NULL)
- {
- s_wdog = wd_create();
- }
+ static struct wdog_s s_wdog;
Review comment:
@masayuki2009 Is there a problem with this? A single static instance
implies that there will be only a single instance of the cxd_rtc_initialize()
active. Is this a valid assumption? This is the only case like this I have
seen in the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
