Re: [PR] nshlib/nsh_builtin.c : Add support to run builtin dirrectly without creating a separate thread [nuttx-apps]

[via GitHub]

wangchdo commented on PR #3168:
URL: https://github.com/apache/nuttx-apps/pull/3168#issuecomment-3272847081

   > > > @wangchdo my comment isn't addressed yet, BTW the build error need fix 
too
   > > 
   > > 
   > > Hi @xiaoxiang781216 I think all your comments have been resolved.
   > > Besides, `builtin->main() `is `main_t`, nornal command handler is 
`nsh_cmd_t` so we can not use a single `handler `variable in `nsh_command()` 
for both builtin command and the normal command handler:
   > > <img alt="image" width="664" height="720" 
src="https://private-user-images.githubusercontent.com/48462264/487035351-fbb6bb87-a33e-49e9-9883-3e597cd3c800.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTc0MDM1OTgsIm5iZiI6MTc1NzQwMzI5OCwicGF0aCI6Ii80ODQ2MjI2NC80ODcwMzUzNTEtZmJiNmJiODctYTMzZS00OWU5LTk4ODMtM2U1OTdjZDNjODAwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA5MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwOTA5VDA3MzQ1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk2OWYzZDllNTMyYmI0NjgyZjNlMjZjY2M3ODUxNGNhZWM0NzhkMGNhZmI0MDllNzQ1ZDliZjBhYjMwZDE5NDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zRr2Dl6Z5UF8jE04aq_m6FeTMVzMPRpRMBN2XpByWko";>
   > > The BV error is not related to this PR, I just re-triggered the CI 
process.
   > 
   > Ok, but even so, it's still better to hook at: 
https://github.com/apache/nuttx-apps/pull/3168/files#diff-9ca19d548babed54b873447075bbc4a436cb578ad869a64c96545f34f8e0e626R1289
 by checking handler isn't equal to cmd_unrecognized.
   
   Hi @xiaoxiang781216  
   
   I suggest first checking whether the user input matches one of the 
built-ins. If it does, call` builtin->main()` and return immediately. 
Otherwise, proceed to check the command list.
   
   This also follows the original parsing sequence in NSH: first built-in apps, 
then the command list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org