tinnedkarma commented on PR #16999: URL: https://github.com/apache/nuttx/pull/16999#issuecomment-3275727879
> @tinnedkarma this is great addition, this way we will have a standard way to communicate with PHY. > > Could you please create a basic Documentation about this driver? Unfortunately your drivers documentation are really "shy", the best references you can use will be: > > https://nuttx.apache.org/docs/latest/components/drivers/special/mtd.html https://nuttx.apache.org/docs/latest/components/drivers/special/lcd.html > > Thank again for your this great contribution Hi @acassis, you are right, I'm also overdue with the documentation for some other contributions. There are things all over the place (my intention are not to be rude, sorry), still figuring out what should get where. I've opened this pull request as draft to have feedback early on for things such as file locations, design approaches and other such big/obvious things. I am working on the documentation in the mean time, but I would need some review over the code to kwon if at least I'm going the right way. If the code needs changes, the documentation will need them as well. There are some things that differs from standard nuttx "approach". Please have a look over them. * The "main" struct is called mdio_bus_s, although from what I can see, nuttx have only devices but no buses, as a difference to other unix-like oses. * Usually, the struct that holds the *ops* is usually statically allocated (g_<arch>_<something>_ops), along with the struct that handles the hardware info/data. I see a lot of uses for the later struct, as a introspection into hardware, but the ops struct feels like littering the global variables space (much more things to search while in gdb), so my stm32 mdio driver does not offer that global ops struct. I'll get this PR out of draft after the documentation is added, but in the mean time, can you have a look over the point above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
