acassis commented on code in PR #16982:
URL: https://github.com/apache/nuttx/pull/16982#discussion_r2341138619
##########
drivers/syslog/syslog_write.c:
##########
@@ -205,9 +206,14 @@ ssize_t syslog_write_foreach(FAR const char *buffer,
}
#endif
}
+
Review Comment:
@wangchdo could you please include a comment before this "if ()" explaining
why do we need it instead of just returning the nwritten?
Something like:
/* Instead of returning the number of written bytes to the last channel,
returns the maximum number of bytes written that was written to some of
existing channel. */
It will be easier to understand and will save time for someone reading this
code in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
