hartmannathan commented on pull request #1545: URL: https://github.com/apache/incubator-nuttx/pull/1545#issuecomment-672176554
On Tue, Aug 11, 2020 at 2:24 PM Xiang Xiao <notificati...@github.com> wrote: > If the compatibility is important, wd_create/wd_delete could keep as > before. But because the new usage use the less memory, more simple and the > conversion is just one line change and be safe(the compiling will fail if > forget), I would prefer to encourage people migrate to the new usage. > As dissussion here #1517 > <https://github.com/apache/incubator-nuttx/pull/1517>: I will prepare > another PR to change the callback from: > > typedef CODE void (*wdentry_t)(int argc, wdparm_t arg1, ...); > > > to: > > typedef CODE void (*wdentry_t)(FAR void *arg); > > > This change has no way to avoid the compatibility issue, but is less error > prone and generate the fast and compact code. > #740 <https://github.com/apache/incubator-nuttx/issues/740> > Reduction in the memory usage is a valid concern. I am OK with it, since a compiler error will alert the downstream users, not fail mysteriously at runtime. <https://github.com/apache/incubator-nuttx/issues/740> > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
