ppisa commented on code in PR #3170: URL: https://github.com/apache/nuttx-apps/pull/3170#discussion_r2347211316
########## netutils/libshvc/Makefile: ########## @@ -0,0 +1,78 @@ +############################################################################# +# apps/netutils/libshvc/Makefile +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################# + +include $(APPDIR)/Make.defs + +SHVDIR = shv-libs4c + +# Commit hash of the supported shv-libs4c revision (master) +SHV_LIBS4C_COMMIT_HASH := a8aa519a85e503a44b819fe3a4919dccc6fd559a + +.PHONY: shv-build-library + +define RUN_OMK_MAKE +$(1):: $(SHVDIR) + make -C $(SHVDIR) \ + CONFIG_SHV_LIBS4C_PLATFORM="nuttx" $(2) \ + CONFIG_OC_ULUT_INCDIRONLY=y \ + EXPORT_LIB_OBJS_EARLY=y \ + CC="$$(CC)" \ + CXX="$$(CXX)" \ + CFLAGS="$$(CFLAGS)" \ + CXXFLAGS="$$(CXXFLAGS)" \ + LD="$$(LD)" \ + LDFLAGS="$$(LDFLAGS)" \ + CONFIG_OC_ULUT_TESTS=n +endef + +define IMPORT_OMK_DEPEND + +$(1) : $$(foreach omk_d,$$(wildcard $(1).d),\ + $$(shell sed -n -e 's/^ \([^\]*\)[\]*$$$$/ \1/p' $$(omk_d))) + +endef + +ifneq ($(wildcard $(SHVDIR)/_build),) +-include $(shell true; find $(SHVDIR)/_build -name 'lib*.a.omkvar') # `true' is a hack for MinGW +SHVOBJS = $(sort $(foreach lib,$(static_libs),$($(lib)_objsar))) +endif + +EXTOBJS += $(SHVOBJS) + +$(SHVOBJS) : shv-build-library + +$(SHVDIR): + $(call CLONE, https://github.com/silicon-heaven/shv-libs4c, $(SHVDIR), ) Review Comment: I am not sure what is the best option. If the repository is already cloned then there should be mechanism how to keep it at the correct version matching given NuttX version/commit. I have implemented next script for integration into [pysimCoder](https://github.com/robertobucher/pysimCoder) https://github.com/zdebanos/pysimCoder/blob/gsoc-2025-shv-refactor/ExtLibs/extlib-fetch.sh It keeps the `local` branch, if the repository is clean it switches it to the specified library version by reset. If there is only small local change which does not clash with switch to newly required commit, it informs user and switches. If there are conflicting changes it fails. If there is another branch and state is clean it switches and it is user's task to move changes. I am not sure what is preferred and typical for NuttX -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
