tinnedkarma commented on code in PR #16999: URL: https://github.com/apache/nuttx/pull/16999#discussion_r2347285840
########## include/nuttx/net/mdio.h: ########## @@ -0,0 +1,208 @@ +/**************************************************************************** + * include/nuttx/net/mdio.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_NUTTX_NET_MDIO_H +#define __INCLUDE_NUTTX_NET_MDIO_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/compiler.h> +#include <stdint.h> +#include <nuttx/mutex.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/**************************************************************************** + * Public Types + ****************************************************************************/ + +/* Forward references */ + +struct mdio_bus_s; +struct mdio_lowerhalf_s; + +/* This structure defines the interface for the MDIO lower-half driver. + * These methods are called by the upper-half MDIO driver. + */ + +struct mdio_ops_s +{ + /* Clause 22 MDIO Read. The first argument is a reference to the + * lower-half driver's private state. + */ + + int (*read)(FAR struct mdio_lowerhalf_s *lower, uint8_t phyaddr, + uint8_t regaddr, FAR uint16_t *value); + + /* Clause 22 MDIO Write */ + + int (*write)(FAR struct mdio_lowerhalf_s *lower, uint8_t phyaddr, + uint8_t regaddr, uint16_t value); Review Comment: Hello, thanks for the feedback. The Clause 45 was indeed left out, my application uses only Clause 22 and cannot test anything C45 related. My thought was to add later on Kconfig defines, for C45, or both C22 C45. Other (RT)OSes I took inspiration offers separate functions for c45 clause (mdio_read/write_c45). I've nothing against adding another parameter to the write function, it we vote this way, but how about I add defines for both c22 and c45 read write functions, I'll update the mdio Kconfig so we can select what clauses are defined. Then the c22 stays as it is and c45 function follows linux-like signature? Anyway, there are others that have work in progress regarding this topic I see. Now is the best time to agree on a solution. @matiamic @michallenc @Cynerd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
