matiamic commented on code in PR #3181: URL: https://github.com/apache/nuttx-apps/pull/3181#discussion_r2350037179
########## netutils/plcatool/CMakeLists.txt: ########## @@ -0,0 +1,33 @@ +# ############################################################################## +# apps/netutils/plcatool/CMakeLists.txt Review Comment: I agree with @ppisa. Support for PLCA in `ethtool` is relatively new (2023) and I think it is not the feature most people use it for. Given it would be the only feature supported in the NuttX version for some time I can imagine this could lead to confusion. Also I think that the eventual `ethtool` implementation should be part of more focused effort in order to achieve correct argument parsing and extensibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
