linguini1 commented on code in PR #17018:
URL: https://github.com/apache/nuttx/pull/17018#discussion_r2353618594


##########
include/syslog.h:
##########
@@ -121,6 +121,8 @@
 #define LOG_INFO      6  /* Informational message */
 #define LOG_DEBUG     7  /* Debug-level message */
 
+#define LOG_LOWOUT   8  /* Log to console straightly for debugging */

Review Comment:
   > @wangchdo please consider using LOG_EMERG instead of LOG_LOWOUT
   
   Isn't this what @xiaoxiang781216 was talking about in the last PR though? 
That the implementation of `LOG_EMERG` was changed from this time of "early 
print" to something else for a specific reason? 
https://github.com/apache/nuttx/pull/16977#issuecomment-3270622862
   
   I think maybe `LOG_LOWOUT` would need to be like `(24 << 3)` to not conflict 
with any implementation so far.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to