raiden00pl commented on code in PR #3170: URL: https://github.com/apache/nuttx-apps/pull/3170#discussion_r2354740835
########## netutils/libshvc/Makefile: ########## @@ -0,0 +1,78 @@ +############################################################################# +# apps/netutils/libshvc/Makefile +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################# + +include $(APPDIR)/Make.defs + +SHVDIR = shv-libs4c + +# Commit hash of the supported shv-libs4c revision (master) +SHV_LIBS4C_COMMIT_HASH := a8aa519a85e503a44b819fe3a4919dccc6fd559a + +.PHONY: shv-build-library + +define RUN_OMK_MAKE +$(1):: $(SHVDIR) + make -C $(SHVDIR) \ + CONFIG_SHV_LIBS4C_PLATFORM="nuttx" $(2) \ + CONFIG_OC_ULUT_INCDIRONLY=y \ + EXPORT_LIB_OBJS_EARLY=y \ + CC="$$(CC)" \ + CXX="$$(CXX)" \ + CFLAGS="$$(CFLAGS)" \ + CXXFLAGS="$$(CXXFLAGS)" \ + LD="$$(LD)" \ + LDFLAGS="$$(LDFLAGS)" \ + CONFIG_OC_ULUT_TESTS=n +endef + +define IMPORT_OMK_DEPEND + +$(1) : $$(foreach omk_d,$$(wildcard $(1).d),\ + $$(shell sed -n -e 's/^ \([^\]*\)[\]*$$$$/ \1/p' $$(omk_d))) + +endef + +ifneq ($(wildcard $(SHVDIR)/_build),) +-include $(shell true; find $(SHVDIR)/_build -name 'lib*.a.omkvar') # `true' is a hack for MinGW +SHVOBJS = $(sort $(foreach lib,$(static_libs),$($(lib)_objsar))) +endif + +EXTOBJS += $(SHVOBJS) + +$(SHVOBJS) : shv-build-library + +$(SHVDIR): + $(call CLONE, https://github.com/silicon-heaven/shv-libs4c, $(SHVDIR), ) Review Comment: I also think we should use a similar approach as in other 3rd party projects to be consistent in the project: download the archive and unpack it. Example here: https://github.com/apache/nuttx-apps/blob/10cab6bf6db16a2c35c3f8363b6cb2586d75e7b6/wireless/bluetooth/nimble/Makefile#L43-L58 By default, if the user only wants to use a 3rd party project, the code will always be downloaded from a verified hash. But skipping the package download when a git repository exists makes the work of developers working on a given 3rd party project much easier. Maintaining the correct version of code when a user uses their own git repo is not a problem. The user has to clone the repository to the correct location, and if they do so, we can assume they're doing it consciously and intentionally. Another thing is that the user may want to use custom 3rd party package with custom patches. With the current solution this is impossible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
