raiden00pl commented on code in PR #17007: URL: https://github.com/apache/nuttx/pull/17007#discussion_r2354516793
########## arch/arm/src/stm32h5/stm32_adc.h: ########## @@ -498,8 +521,8 @@ extern "C" struct adc_dev_s; struct adc_dev_s *stm32h5_adc_initialize(int intf, - const uint8_t *chanlist, - int nchannels); + struct stm32_adc_channel_s *chanlist + , int nchannels); Review Comment: why not add diff channels support like this: https://github.com/raiden00pl/nuttx/commit/181d04cead230f41ac6e4694f28c4ca009f93017 easy to use, simple change, no need to modify pins definitions, compatible with other families and most important doesn't change the API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
