xiaoxiang781216 commented on code in PR #17043:
URL: https://github.com/apache/nuttx/pull/17043#discussion_r2362986184
##########
include/nuttx/arch.h:
##########
@@ -2564,6 +2564,9 @@ void irq_dispatch(int irq, FAR void *context);
#ifdef CONFIG_STACK_COLORATION
struct tcb_s;
size_t up_check_tcbstack(FAR struct tcb_s *tcb);
+#ifdef CONFIG_TASK_STACK_OVERFLOW_CHECK
+bool up_check_tcbstack_overflow(FAR struct tcb_s *tcb);
Review Comment:
why not reuse up_check_tcbstack function
##########
sched/sched/sched_suspendscheduler.c:
##########
@@ -68,6 +68,12 @@ void nxsched_suspend_scheduler(FAR struct tcb_s *tcb)
return;
}
+#ifdef CONFIG_TASK_STACK_OVERFLOW_CHECK
+ /* Check for stack overflow */
+
+ DEBUGASSERT(!up_check_tcbstack_overflow(tcb));
Review Comment:
why not do the check in nxsched_switch_context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
