acassis commented on code in PR #17036:
URL: https://github.com/apache/nuttx/pull/17036#discussion_r2366175871


##########
arch/xtensa/src/esp32/Kconfig:
##########
@@ -1891,6 +1891,12 @@ config ESP32_STORAGE_MTD_SIZE
        ---help---
                MTD size in SPI Flash.
 
+mtd_name = ESP32_STORAGE_MTD
+mtd_part_default_sizes = 8,504,512
+mtd_part_default_names = mtd0p0,mtd0p1,mtd0p2

Review Comment:
   While using:
   
   $ git grep " = " | grep Kconfig
   
   Did return examples like this here.
   
   The Kconfig documentation explains more about it:
   https://docs.kernel.org/kbuild/kconfig-macro-language.html
   
   So, this kind of macros seems correct, although doesn't seem used on NuttX 
Kconfig until now. I don't have strong feeling against it if you cannot find a 
simpler way to implement the same thing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to