suoyuanG commented on PR #17056: URL: https://github.com/apache/nuttx/pull/17056#issuecomment-3322582803
> > It looks like 2 PRs offer similar detection mechanisms: > > ``` > > 1. I prefer the Kconfig definition and dependencies in [sched: add stack overflow check on switch context #17056](https://github.com/apache/nuttx/pull/17056) > > > > 2. I prefer the documentation in [sched/task: Provide a task stack overflow check mechanism in task context switch and task exit #17043](https://github.com/apache/nuttx/pull/17043) > > ``` > > @suoyuanG please incorporate the change. > > > ``` > > 3. I prefer the detection API in up_check_tcbstack() in [sched: add stack overflow check on switch context #17056](https://github.com/apache/nuttx/pull/17056), but [sched/task: Provide a task stack overflow check mechanism in task context switch and task exit #17043](https://github.com/apache/nuttx/pull/17043) offers considerations for protected mode. > > ``` > > do you mean addrenv_select? #17056 already contain the similar code: https://github.com/apache/nuttx/pull/17056/files#diff-64dfd03a85011ec58519af7e0b9471f3573da290fc61d1f6f088265b239346b7L217-L224 > > > Since #17043 took precedence over #17056, I'm inclined to prioritize #17043 and merge the good parts of #17056. > > ps: if patch has conflict, @wangchdo we could add @suoyuanG into co-authored tag "Co-authored-by:" to keep the contributors in git history. > > @xiaoxiang781216 @acassis how do you think? > > no problem. I updated document and added @wangchdo to `Co-authored-by` in git history. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
